142 lines
5.2 KiB
Python
142 lines
5.2 KiB
Python
"""Unit tests for the Z.AI / GLM provider profile's thinking-mode wiring.
|
|
|
|
Z.AI's GLM-4.5-and-later chat models default to thinking-mode ON when the
|
|
request omits ``thinking``. Before the profile emitted the parameter,
|
|
``reasoning_config = {"enabled": False}`` was a silent no-op on the direct
|
|
Z.AI route — users who turned thinking off kept burning thinking tokens on
|
|
every turn (the desktop "thinking reverts to medium" report).
|
|
|
|
These tests pin the profile's wire-shape contract so Z.AI requests stay
|
|
correctly shaped without going live.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def zai_profile():
|
|
"""Resolve the registered Z.AI profile through the real discovery path."""
|
|
# ``model_tools`` triggers plugin discovery on import, which is what
|
|
# registers the Z.AI profile in the global provider registry.
|
|
import model_tools # noqa: F401
|
|
import providers
|
|
|
|
profile = providers.get_provider_profile("zai")
|
|
assert profile is not None, "zai provider profile must be registered"
|
|
return profile
|
|
|
|
|
|
class TestZaiThinkingWireShape:
|
|
"""``build_api_kwargs_extras`` produces Z.AI's exact wire format."""
|
|
|
|
def test_no_preference_omits_thinking(self, zai_profile):
|
|
"""No reasoning_config → omit ``thinking`` so the server default
|
|
applies (matches prior behavior for users with no preference)."""
|
|
extra_body, top_level = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config=None, model="glm-5"
|
|
)
|
|
assert extra_body == {}
|
|
assert top_level == {}
|
|
|
|
def test_enabled_sends_enabled_marker(self, zai_profile):
|
|
extra_body, top_level = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config={"enabled": True, "effort": "medium"}, model="glm-5"
|
|
)
|
|
assert extra_body == {"thinking": {"type": "enabled"}}
|
|
assert top_level == {}
|
|
|
|
def test_explicitly_disabled_sends_disabled_marker(self, zai_profile):
|
|
"""``reasoning_config.enabled=False`` → ``thinking.type=disabled``.
|
|
|
|
The crucial bit is that the parameter is *sent* at all — GLM defaults
|
|
to thinking-on when ``thinking`` is absent, so an unsent disable
|
|
burns thinking tokens forever.
|
|
"""
|
|
extra_body, top_level = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config={"enabled": False}, model="glm-5"
|
|
)
|
|
assert extra_body == {"thinking": {"type": "disabled"}}
|
|
assert top_level == {}
|
|
|
|
def test_no_effort_levels_leak_to_top_level(self, zai_profile):
|
|
"""GLM has no effort knob — never emit ``reasoning_effort``."""
|
|
for effort in ("minimal", "low", "medium", "high", "xhigh"):
|
|
_, top_level = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config={"enabled": True, "effort": effort}, model="glm-5.2"
|
|
)
|
|
assert top_level == {}
|
|
|
|
|
|
class TestZaiModelGating:
|
|
"""GLM 4.5+ get thinking; earlier GLM models are left untouched."""
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
[
|
|
"glm-4.5",
|
|
"glm-4.5-air",
|
|
"glm-4.5-flash",
|
|
"glm-4.6",
|
|
"glm-5",
|
|
"glm-5.2",
|
|
"GLM-5", # case-insensitive
|
|
],
|
|
)
|
|
def test_thinking_capable_models_emit_thinking(self, zai_profile, model):
|
|
extra_body, _ = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config={"enabled": False}, model=model
|
|
)
|
|
assert extra_body == {"thinking": {"type": "disabled"}}
|
|
|
|
@pytest.mark.parametrize(
|
|
"model",
|
|
[
|
|
"glm-4-9b", # pre-4.5, no thinking param
|
|
"glm-4",
|
|
"glm-3-turbo",
|
|
"", # bare/unknown
|
|
None, # missing
|
|
"charglm-3", # non-GLM-versioned id
|
|
],
|
|
)
|
|
def test_non_thinking_models_emit_nothing(self, zai_profile, model):
|
|
extra_body, top_level = zai_profile.build_api_kwargs_extras(
|
|
reasoning_config={"enabled": False}, model=model
|
|
)
|
|
assert extra_body == {}
|
|
assert top_level == {}
|
|
|
|
|
|
class TestZaiFullKwargsIntegration:
|
|
"""End-to-end: the transport's full kwargs carry the thinking marker."""
|
|
|
|
def test_disabled_reaches_the_wire(self, zai_profile):
|
|
from agent.transports.chat_completions import ChatCompletionsTransport
|
|
|
|
kwargs = ChatCompletionsTransport().build_kwargs(
|
|
model="glm-5",
|
|
messages=[{"role": "user", "content": "ping"}],
|
|
tools=None,
|
|
provider_profile=zai_profile,
|
|
reasoning_config={"enabled": False},
|
|
base_url="https://api.z.ai/api/paas/v4",
|
|
provider_name="zai",
|
|
)
|
|
assert kwargs["extra_body"]["thinking"] == {"type": "disabled"}
|
|
|
|
def test_no_preference_keeps_wire_clean(self, zai_profile):
|
|
from agent.transports.chat_completions import ChatCompletionsTransport
|
|
|
|
kwargs = ChatCompletionsTransport().build_kwargs(
|
|
model="glm-5",
|
|
messages=[{"role": "user", "content": "ping"}],
|
|
tools=None,
|
|
provider_profile=zai_profile,
|
|
reasoning_config=None,
|
|
base_url="https://api.z.ai/api/paas/v4",
|
|
provider_name="zai",
|
|
)
|
|
assert "thinking" not in kwargs.get("extra_body", {})
|