emma-hermes/tests/hermes_cli
Ben Barclay a46462ec65
fix(cli): persist custom --portal-url to .env on dashboard register (#42435)
* fix(cli): persist custom --portal-url to .env on dashboard register

`hermes dashboard register --portal-url <url>` resolved the custom portal
for the registration request but only persisted it to .env when the var was
absent AND non-default. So a user who re-registered against a different
portal (e.g. switching preview deploys) silently kept the stale
HERMES_DASHBOARD_PORTAL_URL, and an explicit request for the production
portal was never written at all.

Track whether a custom portal was *explicitly supplied* (--portal-url flag
or HERMES_DASHBOARD_PORTAL_URL env), separately from the resolved value:

  - explicit custom URL -> always persist (update in place via
    save_env_value, which overwrites the matching key rather than appending
    a duplicate), even when it equals the production default; no-op when it
    already matches.
  - no custom URL supplied -> unchanged conservative behaviour: only write an
    inferred portal when absent and non-default; never alter an existing
    entry unexpectedly.

save_env_value already preserves other lines/comments and dedups in place;
this only changes the decision of *when* to call it.

Adds TestCustomPortalPersistence covering all four cases.

Co-authored-by: Hermes Agent <agent@nousresearch.com>

* feat(cli): persist dashboard public URL from --redirect-uri on register

When the user registers a publicly-exposed dashboard with --redirect-uri
(the full OAuth callback, e.g. https://hermes.example.com/auth/callback),
derive its origin and persist it as HERMES_DASHBOARD_PUBLIC_URL — the env var
the dashboard auth layer actually consumes at serve time.

dashboard_auth/routes._redirect_uri reconstructs the callback as
HERMES_DASHBOARD_PUBLIC_URL + "/auth/callback" (verbatim), and
dashboard_auth/prefix.resolve_public_url reads that var (then config.yaml
dashboard.public_url) to decide the public origin. Previously --redirect-uri
was sent to the portal at registration but never persisted, so the operator
had to set HERMES_DASHBOARD_PUBLIC_URL by hand for the login gate to engage
and the callback to round-trip. We now wire it automatically.

Persist the ORIGIN (scheme://host[:port]), not the full callback path —
persisting the raw redirect would double the path when the runtime appends
/auth/callback. Mirrors the portal-url persistence semantics already in this
PR: always write an explicitly-derived value (updating in place, no
duplicate), no-op when it already matches, never written on a localhost-only
install (no --redirect-uri), and skipped for a non-http(s)/malformed redirect.

Verified end-to-end: cmd_dashboard_register writes the origin to .env, then
resolve_public_url() reads it back and public_url + /auth/callback
reconstructs exactly the originally-supplied --redirect-uri.

Adds TestPublicUrlPersistence (8 cases) incl. origin-derivation, port
preservation, update-in-place, no-op, no-flag, non-http skip, and
both-portal-and-public-url-persisted.

Co-authored-by: Hermes Agent <agent@nousresearch.com>

---------

Co-authored-by: Hermes Agent <agent@nousresearch.com>
2026-06-09 13:56:33 +10:00
..
__init__.py
conftest.py
conftest_dashboard_auth.py
test_active_sessions.py feat(sessions): add optional max session cap 2026-06-08 15:12:12 -07:00
test_anthropic_model_flow_stale_oauth.py
test_anthropic_oauth_flow.py
test_anthropic_provider_persistence.py
test_api_key_providers.py
test_apply_model_switch_result_context.py
test_apply_profile_override.py
test_arcee_provider.py
test_argparse_flag_propagation.py
test_at_context_completion_filter.py
test_atomic_json_write.py
test_atomic_yaml_write.py
test_auth_codex_provider.py fix(auth): preserve independent Codex pool entries on re-auth (#39236) 2026-06-08 11:57:03 -07:00
test_auth_commands.py fix(auth): add Codex OAuth accounts as distinct pool entries 2026-06-08 11:57:03 -07:00
test_auth_loopback_ssh_hint.py
test_auth_manual_paste.py
test_auth_nous_provider.py
test_auth_profile_fallback.py
test_auth_provider_gate.py
test_auth_qwen_provider.py
test_auth_ssl_macos.py
test_auth_toctou_file_modes.py
test_auth_usable_secret.py
test_auth_xai_oauth_provider.py
test_aux_config.py
test_azure_detect.py
test_azure_foundry_entra.py
test_backup.py
test_banner.py
test_banner_git_state.py
test_banner_pip_update.py
test_banner_skills.py
test_bedrock_model_picker.py
test_build_info.py
test_bundles.py
test_chat_skills_flag.py
test_claw.py
test_clear_stale_base_url.py
test_cli_active_session_limit.py feat(sessions): add optional max session cap 2026-06-08 15:12:12 -07:00
test_cli_output.py
test_cmd_update.py fix: align test fixture arg order + add zakame to AUTHOR_MAP 2026-06-06 18:22:20 -07:00
test_cmd_update_docker.py
test_coalesce_session_args.py
test_codex_cli_model_picker.py
test_codex_models.py
test_codex_runtime_plugin_migration.py
test_codex_runtime_switch.py
test_commands.py
test_completion.py
test_config.py fix(config): preserve custom-provider models maps and metadata through v11->v12 migration (#40573) 2026-06-06 18:43:20 -07:00
test_config_drift.py
test_config_env_expansion.py
test_config_env_refs.py
test_config_validation.py
test_container_aware_cli.py
test_container_boot.py
test_copilot_auth.py
test_copilot_catalog_oauth_fallback.py
test_copilot_context.py
test_copilot_in_model_list.py
test_copilot_token_exchange.py
test_cron.py
test_curator_archive_prune.py
test_curator_recent_run_notice.py
test_curator_run.py
test_curator_status.py
test_curses_arrow_keys.py test: skip curses tests on Windows where _curses is unavailable (#40611) 2026-06-07 18:21:03 -07:00
test_curses_color_compat.py test: skip curses tests on Windows where _curses is unavailable (#40611) 2026-06-07 18:21:03 -07:00
test_curses_ui_fuzzy_rank.py
test_curses_ui_search.py
test_custom_provider_context_length.py
test_custom_provider_model_switch.py
test_dashboard_admin_endpoints.py feat(dashboard): return recent commits from /api/hermes/update/check 2026-06-08 08:58:26 -07:00
test_dashboard_auth_401_reauth.py
test_dashboard_auth_audit.py
test_dashboard_auth_cookies.py
test_dashboard_auth_gate.py
test_dashboard_auth_middleware.py
test_dashboard_auth_password_login.py
test_dashboard_auth_plugin_hook.py
test_dashboard_auth_prefix.py
test_dashboard_auth_provider_base.py
test_dashboard_auth_status_endpoint.py
test_dashboard_auth_stub_provider.py
test_dashboard_auth_ws_auth.py
test_dashboard_auth_ws_tickets.py
test_dashboard_browser_safe_imports.py
test_dashboard_lifecycle_flags.py
test_dashboard_profiles_nav_label.py
test_dashboard_register.py fix(cli): persist custom --portal-url to .env on dashboard register (#42435) 2026-06-09 13:56:33 +10:00
test_dashboard_tui_backcompat.py
test_debug.py
test_default_interface_resolution.py
test_dep_ensure.py
test_deprecated_cwd_warning.py
test_destructive_slash_confirm_gate.py
test_detect_api_mode_for_url.py
test_determine_api_mode_hostname.py
test_dingtalk_auth.py
test_discord_skill_clamp_warning.py
test_doctor.py fix(doctor): allow vendor slugs for named custom providers 2026-06-08 15:53:09 -07:00
test_doctor_command_install.py
test_doctor_dedicated_provider_skip.py
test_dump_git_commit.py
test_ensure_hermes_home_uid_34107.py
test_env_load_cache.py
test_env_loader.py
test_env_sanitize_on_load.py
test_fallback_cmd.py
test_gateway.py
test_gateway_linger.py
test_gateway_platform_gating.py
test_gateway_proc_fallback.py
test_gateway_restart_loop.py
test_gateway_runtime_health.py
test_gateway_s6_dispatch.py
test_gateway_service.py fix(gateway): drop --replace from systemd unit templates (#41892) 2026-06-08 00:20:08 -07:00
test_gateway_service_paths.py
test_gateway_windows.py
test_gateway_wsl.py fix(gateway,windows): reliability — JOB breakaway + status --deep probes + test-leak fix (#40909) 2026-06-06 19:53:58 -07:00
test_gemini_free_tier_setup_block.py
test_gemini_provider.py
test_gmi_provider.py
test_goals.py
test_graphical_browser_detection.py
test_gui_command.py fix(desktop): stop running Hermes.exe locking win-unpacked before Windows pack (#42100) 2026-06-08 11:51:31 -07:00
test_gui_uninstall.py feat: uninstall the Chat GUI without removing the agent (CLI + desktop UI) (#40355) 2026-06-06 18:22:38 -07:00
test_hooks_cli.py
test_ignore_user_config_flags.py
test_image_gen_picker.py
test_install_cua_driver.py
test_inventory.py refactor(inventory): make force_fresh_nous_tier keyword-only + pin contract 2026-06-07 00:41:13 -07:00
test_inventory_pricing.py
test_kanban_blocked_sticky.py
test_kanban_boards.py
test_kanban_cli.py
test_kanban_cli_dispatch_passthrough.py
test_kanban_core_functionality.py refactor(gateway): extract kanban watcher loops into GatewayKanbanWatchersMixin (god-file Phase 3) 2026-06-07 23:14:18 -07:00
test_kanban_db.py fix(kanban): sweep deferred scratch parent on non-scratch child completion + tests 2026-06-07 09:50:44 -07:00
test_kanban_db_init.py
test_kanban_decompose.py
test_kanban_decompose_db.py
test_kanban_default_assignee.py
test_kanban_diagnostics.py
test_kanban_goal_mode.py
test_kanban_notify.py
test_kanban_per_profile_cap.py
test_kanban_promote.py
test_kanban_specify.py
test_kanban_specify_db.py
test_kanban_swarm.py
test_kanban_worker_image_extraction.py
test_launcher.py
test_list_picker_providers.py
test_logs.py
test_managed_installs.py
test_managed_uv.py
test_mcp_add_command_dest.py
test_mcp_catalog.py
test_mcp_config.py
test_mcp_reload_confirm_gate.py
test_mcp_startup.py
test_mcp_tools_config.py
test_memory_reset.py
test_memory_setup_provider_arg.py
test_migrate_xai.py
test_model_catalog.py
test_model_normalize.py
test_model_picker_viewport.py
test_model_provider_persistence.py
test_model_switch_context_display.py
test_model_switch_copilot_api_mode.py
test_model_switch_custom_providers.py fix(doctor): allow vendor slugs for named custom providers 2026-06-08 15:53:09 -07:00
test_model_switch_opencode_anthropic.py
test_model_switch_variant_tags.py
test_model_validation.py
test_models.py
test_models_dev_preferred_merge.py
test_non_ascii_credential.py
test_nous_account.py
test_nous_auth_status_cache.py
test_nous_hermes_non_agentic.py
test_nous_inference_url_validation.py
test_nous_subscription.py
test_ollama_cloud_auth.py
test_ollama_cloud_provider.py
test_openai_codex_model_validation_fallback.py
test_openai_picker_curated.py
test_opencode_go_flat_namespace.py
test_opencode_go_in_model_list.py
test_opencode_go_validation_fallback.py
test_overlay_slug_resolution.py
test_path_completion.py
test_picker_prewarm.py
test_pin_kanban_board_env.py
test_pip_install_detection.py
test_placeholder_usage.py
test_plugin_auxiliary_tasks.py
test_plugin_cli_registration.py
test_plugin_scanner_recursion.py
test_plugins.py
test_plugins_cmd.py
test_plugins_cmd_category_discovery.py fix(plugins): discover nested category plugins in 'plugins list' (issue #41066) 2026-06-07 08:02:55 +00:00
test_plugins_cmd_enable_disable_nested.py fix(plugins): alias-normalize enable/disable for nested category plugins (follow-up to #41076) 2026-06-08 17:57:37 +05:30
test_plugins_cmd_list.py fix(plugins): alias-normalize enable/disable for nested category plugins (follow-up to #41076) 2026-06-08 17:57:37 +05:30
test_plugins_transcription_registration.py
test_plugins_tts_registration.py
test_portal_cli.py
test_post_setup_gating.py
test_profile_describer.py
test_profile_distribution.py fix(dist): stop USER_OWNED_EXCLUDE from filtering nested directories 2026-06-07 21:50:57 -07:00
test_profile_export_credentials.py
test_profiles.py
test_profiles_s6_hooks.py
test_project_plugin_rce_bypass.py
test_prompt_api_key.py
test_prompt_size.py
test_provider_config_validation.py
test_provider_groups.py
test_proxy.py
test_psutil_android_extract.py
test_pty_bridge.py fix(pty-bridge): terminate PTY process groups on teardown 2026-06-08 07:03:12 -07:00
test_reasoning_effort_menu.py
test_redact_config_bridge.py
test_regression_16767.py
test_relaunch.py
test_resolve_last_session.py
test_resolve_provider_openrouter_pool.py fix(auth): auto-detect OpenRouter credential from the pool, not just env (#42263) 2026-06-08 10:01:47 -07:00
test_run_with_idle_timeout.py
test_runtime_provider_resolution.py
test_secret_prompt.py
test_secrets_bitwarden_non_tty.py fix(secrets): fail early with clear error when bitwarden setup runs without TTY (#40571) 2026-06-06 18:36:40 -07:00
test_security_advisories.py
test_security_audit.py
test_send_cmd.py
test_service_manager.py
test_session_browse.py
test_session_handoff.py
test_session_recap.py
test_sessions_delete.py
test_set_config_value.py
test_setup.py
test_setup_agent_settings.py
test_setup_hermes_script.py
test_setup_irc.py
test_setup_matrix_e2ee.py
test_setup_menu_curses_migration.py
test_setup_model_provider.py
test_setup_noninteractive.py
test_setup_ollama_cloud_force_refresh.py refactor(cli): extract 18 model-flow wizard functions into model_setup_flows (god-file Phase 2) 2026-06-08 09:42:44 -07:00
test_setup_openclaw_migration.py
test_setup_prompt_menus.py
test_setup_reconfigure.py
test_signal_handler_kanban_worker.py
test_skills_config.py
test_skills_hub.py
test_skills_install_flags.py
test_skills_skip_confirm.py
test_skills_subparser.py
test_skin_engine.py
test_slack_cli.py
test_spotify_auth.py
test_startup_plugin_gating.py
test_status.py
test_status_model_provider.py
test_subcommands_batch.py refactor(cli): extract 25 more subcommand parsers into hermes_cli/subcommands/ 2026-06-07 22:18:14 -07:00
test_subcommands_cron.py refactor(cli): extract hermes cron parser into hermes_cli/subcommands/ (god-file Phase 2) 2026-06-07 22:18:14 -07:00
test_subcommands_followup.py refactor(cli): promote 9 closure handlers to top-level + extract their parsers (god-file Phase 2 follow-up) 2026-06-07 22:56:23 -07:00
test_subcommands_profile_gateway.py refactor(cli): extract profile + gateway/proxy parsers into hermes_cli/subcommands/ 2026-06-07 22:18:14 -07:00
test_subparser_routing_fallback.py
test_subprocess_timeouts.py
test_suppress_eio_on_interrupt.py
test_systemd_optional_directives.py fix(gateway): normalize optional systemd directives in stale-check (#41119) 2026-06-07 21:50:57 -07:00
test_teams_pipeline_plugin_cli.py
test_telegram_managed_bot.py
test_tencent_tokenhub_provider.py
test_terminal_menu_fallbacks.py
test_timeouts.py
test_tips.py
test_tool_token_estimation.py
test_tools_config.py
test_tools_disable_enable.py
test_tts_picker.py
test_tui_bundled.py
test_tui_heap_sizing.py
test_tui_mouse_residue_suppression.py
test_tui_npm_install.py test: update non-Termux workspace-scope fixtures for #38358 fix 2026-06-06 18:22:20 -07:00
test_tui_resume_flow.py
test_uninstall_node_symlinks.py
test_update_autostash.py fix(update): scope git fetch to target branch 2026-06-08 15:24:31 -04:00
test_update_check.py
test_update_concurrent_quarantine.py
test_update_config_clears_custom_fields.py
test_update_hangup_protection.py
test_update_post_pull_syntax_guard.py
test_update_stale_dashboard.py
test_update_yes_flag.py
test_update_zip_symlink_reject.py
test_user_providers_model_switch.py
test_uv_tool_update.py
test_verify_core_dependencies.py
test_video_gen_picker.py
test_voice_wrapper.py
test_web_oauth_dispatch.py
test_web_server.py fix(session): follow compression continuations for transcript reads 2026-06-07 23:57:20 -07:00
test_web_server_cron_profiles.py
test_web_server_host_header.py
test_web_server_oauth_write.py
test_web_server_pty_import.py feat(windows): enable dashboard /chat tab via ConPTY (win_pty_bridge) + tests (#42251) 2026-06-08 11:32:43 -07:00
test_web_server_session_search.py
test_web_ui_build.py test: update non-Termux workspace-scope fixtures for #38358 fix 2026-06-06 18:22:20 -07:00
test_webhook_cli.py
test_whatsapp_setup_ordering.py
test_win_pty_bridge.py feat(windows): enable dashboard /chat tab via ConPTY (win_pty_bridge) + tests (#42251) 2026-06-08 11:32:43 -07:00
test_windows_native_docs.py docs(windows): fix Get-Command PATH guidance to venv\Scripts\hermes.exe (#40613) 2026-06-07 18:28:23 -07:00
test_xai_oauth_pkce_token_exchange.py
test_xai_provider_labels.py
test_xai_retirement.py
test_xiaomi_provider.py